linux-kernel - Re: [PATCH -next] dma: bcm-sba-raid: fix build errors and dependencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOCOHw4uuYru7cdP64V5NBA04ZRLtsdQhvwRc6pUZpM1YEozMg@mail.gmail.com>
Date:   Wed, 17 May 2017 11:11:24 -0700
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Anup Patel <anup.patel@...adcom.com>,
        Vinod Koul <vinod.koul@...el.com>,
        "dmaengine@...r.kernel.org" <dmaengine@...r.kernel.org>
Subject: Re: [PATCH -next] dma: bcm-sba-raid: fix build errors and dependencies

On Wed, May 17, 2017 at 9:40 AM, Randy Dunlap <rdunlap@...radead.org> wrote:
> From: Randy Dunlap <rdunlap@...radead.org>
>
> Fix build errors when COMPILE_TEST is enabled but RAID6_PQ is not
> enabled (seen on x86_64).
>
> drivers/built-in.o: In function `sba_prep_dma_pq_req':
> (.text+0x16132): undefined reference to `raid6_gflog'
> drivers/built-in.o: In function `sba_prep_dma_pq_single_req':
> (.text+0x162f4): undefined reference to `raid6_gflog'
>
> This driver needs RAID6_PQ and MAILBOX (from inspection) independent of
> ARM64 or COMPILE_TEST.
>
> However, RAID6_PQ is not defined in any Kconfig file, although it is
> used in several of them. :(
>
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Anup Patel <anup.patel@...adcom.com>
> Cc: Vinod Koul <vinod.koul@...el.com>
> Cc: dmaengine@...r.kernel.org

Hit this as well today.

Acked-by: Bjorn Andersson <bjorn.andersson@...aro.org>

Regards,
Bjorn