lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 17 May 2017 22:58:50 +0100 From: Colin King <colin.king@...onical.com> To: Anup Patel <anup.patel@...adcom.com>, Dan Williams <dan.j.williams@...el.com>, Vinod Koul <vinod.koul@...el.com>, dmaengine@...r.kernel.org Cc: kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org Subject: [PATCH][V2] dmaengine: bcm-scm-raid: remove redundant null check on req From: Colin Ian King <colin.king@...onical.com> Req is never null on at the point of the null check, so remove this redundant check and just return &req->tx. Detected by CoverityScan, CID#1436147 ("Logically dead code") Signed-off-by: Colin Ian King <colin.king@...onical.com> --- drivers/dma/bcm-sba-raid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/bcm-sba-raid.c b/drivers/dma/bcm-sba-raid.c index 7daa883eeded..8246c26eabe5 100644 --- a/drivers/dma/bcm-sba-raid.c +++ b/drivers/dma/bcm-sba-raid.c @@ -582,7 +582,7 @@ sba_prep_dma_interrupt(struct dma_chan *dchan, unsigned long flags) req->tx.flags = flags; req->tx.cookie = -EBUSY; - return (req) ? &req->tx : NULL; + return &req->tx; } static void sba_fillup_memcpy_msg(struct sba_request *req, -- 2.11.0
Powered by blists - more mailing lists