linux-kernel - Re: [PATCH][V2] dmaengine: bcm-scm-raid: remove redundant null check on req

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170519032550.GL15061@localhost>
Date:   Fri, 19 May 2017 08:55:50 +0530
From:   Vinod Koul <vinod.koul@...el.com>
To:     Colin King <colin.king@...onical.com>
Cc:     Anup Patel <anup.patel@...adcom.com>,
        Dan Williams <dan.j.williams@...el.com>,
        dmaengine@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH][V2] dmaengine: bcm-scm-raid: remove redundant null check
 on req

On Wed, May 17, 2017 at 10:58:50PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Req is never null on at the point of the null check, so
> remove this redundant check and just return &req->tx.
> 
> Detected by CoverityScan, CID#1436147 ("Logically dead code")


Applied, thanks

-- 
~Vinod