lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 18 May 2017 19:49:21 +0300 From: Andy Shevchenko <andy.shevchenko@...il.com> To: Mika Westerberg <mika.westerberg@...ux.intel.com> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Andreas Noever <andreas.noever@...il.com>, Michael Jamet <michael.jamet@...el.com>, Yehezkel Bernat <yehezkel.bernat@...el.com>, Lukas Wunner <lukas@...ner.de>, Amir Levy <amir.jer.levy@...el.com>, Andy Lutomirski <luto@...nel.org>, Mario Limonciello <Mario.Limonciello@...l.com>, Jared.Dominguez@...l.com, Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH 07/24] thunderbolt: Convert switch to a device On Thu, May 18, 2017 at 5:38 PM, Mika Westerberg <mika.westerberg@...ux.intel.com> wrote: > Thunderbolt domain consists of switches that are connected to each > other, forming a bus. This will convert each switch into a real Linux > device structure and adds them to the domain. The advantage here is > that we get all the goodies from the driver core, like reference > counting and sysfs hierarchy for free. > > Also expose device identification information to the userspace via new > sysfs attributes. > > In order to support internal connection manager (ICM) we separate switch > configuration into its own function (tb_switch_configure()) which is > only called by the existing native connection manager implementation > used on Macs. > Couple of nits below. > + > + return sw; > +err: Perhaps err_free_sw_ports: ? > + kfree(sw->ports); > + kfree(sw); > + return NULL; > +} > + /* upload configuration */ > + ret = tb_sw_write(sw, 1 + (u32 *) &sw->config, TB_CFG_SWITCH, 1, 3); Extra space before &. > + if (ret) > + return ret; -- With Best Regards, Andy Shevchenko
Powered by blists - more mailing lists