linux-kernel - Re: [PATCH 10/24] thunderbolt: Read vendor and device name from DROM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VfW8=5Ms2xzOf3WOxmSN1DS9H_ETCC=Z=Ns+KD28i9eHA@mail.gmail.com>
Date:   Thu, 18 May 2017 22:19:11 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Mika Westerberg <mika.westerberg@...ux.intel.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Andreas Noever <andreas.noever@...il.com>,
        Michael Jamet <michael.jamet@...el.com>,
        Yehezkel Bernat <yehezkel.bernat@...el.com>,
        Lukas Wunner <lukas@...ner.de>,
        Amir Levy <amir.jer.levy@...el.com>,
        Andy Lutomirski <luto@...nel.org>,
        Mario Limonciello <Mario.Limonciello@...l.com>,
        Jared.Dominguez@...l.com,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 10/24] thunderbolt: Read vendor and device name from DROM

On Thu, May 18, 2017 at 5:39 PM, Mika Westerberg
<mika.westerberg@...ux.intel.com> wrote:
> The device DROM contains name of the vendor and device among other
> things. Extract this information and expose it to the userspace via two
> new attributes.

One nit below.

> +       switch (header->type) {
> +       case TB_DROM_ENTRY_PORT:
> +               break;
> +       case TB_DROM_ENTRY_GENERIC:

> +               tb_drom_parse_generic_entry(sw,
> +                       (struct tb_drom_entry_generic *)header);

Can it be one line?
Is fall through intended?

> +       default:
>                 return 0;
> +       }

-- 
With Best Regards,
Andy Shevchenko