linux-kernel - Re: [PATCH v10 2/3] fpga manager: Add altera-ps-spi driver for Altera FPGAs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170518225935.7948d7a5@crub>
Date:   Thu, 18 May 2017 22:59:35 +0200
From:   Anatolij Gustschin <agust@...x.de>
To:     stillcompiling@...il.com, joshua.clayton@...west.com,
        bst@...gutronix.de
Cc:     linux-fpga@...r.kernel.org, atull@...nel.org,
        moritz.fischer@...us.com, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, robh+dt@...nel.org,
        mark.rutland@....com
Subject: Re: [PATCH v10 2/3] fpga manager: Add altera-ps-spi driver for
 Altera FPGAs

On Wed, 17 May 2017 20:23:41 +0200
Anatolij Gustschin agust@...x.de wrote:
...
>+	if (!IS_ERR(conf->confd)) {
>+		if (!gpiod_get_raw_value_cansleep(conf->confd)) {
>+			dev_err(&mgr->dev, "CONF_DONE is low!\n");

as we agreed in the another thread, gpiod_get_value_cansleep()
should be used here. Another change: s/low/inactive/

--
Anatolij