linux-kernel - Re: [PATCH v10 2/3] fpga manager: Add altera-ps-spi driver for Altera FPGAs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170518134659.589b681b@crub>
Date:   Thu, 18 May 2017 13:46:59 +0200
From:   Anatolij Gustschin <agust@...x.de>
To:     stillcompiling@...il.com, joshua.clayton@...west.com,
        bst@...gutronix.de
Cc:     linux-fpga@...r.kernel.org, atull@...nel.org,
        moritz.fischer@...us.com, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, robh+dt@...nel.org,
        mark.rutland@....com
Subject: Re: [PATCH v10 2/3] fpga manager: Add altera-ps-spi driver for
 Altera FPGAs

Hi,

On Wed, 17 May 2017 20:23:41 +0200
Anatolij Gustschin agust@...x.de wrote:
...
>+	conf->spi = spi;
>+	conf->config = devm_gpiod_get(&spi->dev, "nconfig", GPIOD_OUT_HIGH);

we should use GPIOD_OUT_LOW flags here. nCONFIG is low active, so
setting logical high will enable the signal (drive the pin low),
resulting in configuration reset for already initialised FPGAs when
loading/reloading the module.

Thanks,

Anatolij