linux-kernel - Re: [PATCH-stable] serial: samsung: Bring back removed variable to fix compilation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJKOXPdEQ-JSSZK1PA4xc1f7NWdKNyaeQ3qyjEdW7ttTvTF4og@mail.gmail.com>
Date:   Thu, 18 May 2017 14:59:32 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Krzysztof Kozlowski <kozik.server@...il.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jslaby@...e.com>, linux-serial@...r.kernel.org,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH-stable] serial: samsung: Bring back removed variable to
 fix compilation

On Thu, May 18, 2017 at 2:31 PM, Krzysztof Kozlowski
<kozik.server@...il.com> wrote:

I need to fixup the from field. It should be krzk@...nel.org.

Krzysztof


> By mistake commit 500fcc08a32b ("serial: samsung: Add missing checks for
> dma_map_single failure") removes a local variable which is still used by
> code.  After backporting the commit to stable, compilation fails:
>
>         drivers/tty/serial/samsung.c: In function ‘s3c24xx_serial_request_dma’:
>         drivers/tty/serial/samsung.c:909:45: error: ‘flags’ undeclared (first use in this function)
>
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
>
> ---
>
> Fix for stable-rc commit:
> bc3ac2299c4873cdc7f9bf3c867c23e9714a036f
> ---
>  drivers/tty/serial/samsung.c | 1 +
>  1 file changed, 1 insertion(+)