linux-kernel - Re: [PATCH 3/3][v4] staging: fsl-mc: move bus driver out of staging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 19 May 2017 17:57:27 -0500
From:   Stuart Yoder <b08248@...il.com>
To:     Matthias Brugger <matthias.bgg@...il.com>
Cc:     laurentiu.tudor@....com, gregkh@...uxfoundation.org,
        Stuart Yoder <stuyoder@...il.com>, devel@...verdev.osuosl.org,
        Arnd Bergmann <arnd@...db.de>, ruxandra.radulescu@....com,
        Marc Zyngier <marc.zyngier@....com>,
        Stuart Yoder <stuart.yoder@....com>, roy.pledge@....com,
        linux-kernel@...r.kernel.org, Alexander Graf <agraf@...e.de>,
        catalin.horghidan@....com, ioana.ciornei@....com,
        Thomas Gleixner <tglx@...utronix.de>, leoyang.li@....com,
        bharat.bhushan@....com, Jason Cooper <jason@...edaemon.net>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        Rob Herring <robh+dt@...nel.org>
Subject: Re: [PATCH 3/3][v4] staging: fsl-mc: move bus driver out of staging

On Fri, May 19, 2017 at 8:41 AM, Matthias Brugger
<matthias.bgg@...il.com> wrote:
>
>
> On 19/05/17 15:13, laurentiu.tudor@....com wrote:
>>
>> From: Stuart Yoder <stuart.yoder@....com>
>>
>> Move the source files out of staging into their final locations:
>>    -include files in drivers/staging/fsl-mc/include go to
>> include/linux/fsl
>>    -irq-gic-v3-its-fsl-mc-msi.c goes to drivers/irqchip
>
>
> This driver has as compatible "arm,gic-v3-its". I wonder if this is correct
> and if it should be moved like this out of staging.

Matthias, can you be more specific as to what your concern is?

The fsl-mc bus needs to implement bus specific gic-v3 MSI support just
like the other
bus types.  See:
   drivers/irqchip/irq-gic-v3-its-pci-msi.c
   drivers/irqchip/irq-gic-v3-its-platform-msi.c

You will see that the PCI and platform bus types also find the gic-v3 node by
compatible string.

The bus specific gic-v3 support for fsl-mc is implemented in a
completely standard way.

Thanks,
Stuart