[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <519997CE-E94C-40E3-96A7-48CA682B553E@gmail.com>
Date: Mon, 22 May 2017 16:24:23 -0700
From: Nadav Amit <nadav.amit@...il.com>
To: Andy Lutomirski <luto@...nel.org>
Cc: X86 ML <x86@...nel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
Borislav Petkov <bpetkov@...e.de>,
Linus Torvalds <torvalds@...ux-foundation.org>,
Andrew Morton <akpm@...ux-foundation.org>,
Mel Gorman <mgorman@...e.de>,
"linux-mm@...ck.org" <linux-mm@...ck.org>,
Rik van Riel <riel@...hat.com>,
Dave Hansen <dave.hansen@...el.com>,
Nadav Amit <namit@...are.com>, Michal Hocko <mhocko@...e.com>,
Arjan van de Ven <arjan@...ux.intel.com>
Subject: Re: [PATCH v2 10/11] x86/mm: Be more consistent wrt PAGE_SHIFT vs
PAGE_SIZE in tlb flush code
>
> /* Balance as user space task's flush, a bit conservative */
> if (end == TLB_FLUSH_ALL ||
> - (end - start) > tlb_single_page_flush_ceiling * PAGE_SIZE) {
> + (end - start) > tlb_single_page_flush_ceiling >> PAGE_SHIFT) {
Shouldn’t it be << ?
Nadav
Powered by blists - more mailing lists