linux-kernel - Re: [PATCH v2 10/11] x86/mm: Be more consistent wrt PAGE_SHIFT vs PAGE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALCETrV7_U-Noxho8WjwogBtHDs49pOujVKQze+4JtTQbiCRKQ@mail.gmail.com>
Date:   Mon, 22 May 2017 16:41:50 -0700
From:   Andy Lutomirski <luto@...nel.org>
To:     Nadav Amit <nadav.amit@...il.com>
Cc:     Andy Lutomirski <luto@...nel.org>, X86 ML <x86@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Borislav Petkov <bpetkov@...e.de>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Mel Gorman <mgorman@...e.de>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        Rik van Riel <riel@...hat.com>,
        Dave Hansen <dave.hansen@...el.com>,
        Nadav Amit <namit@...are.com>, Michal Hocko <mhocko@...e.com>,
        Arjan van de Ven <arjan@...ux.intel.com>
Subject: Re: [PATCH v2 10/11] x86/mm: Be more consistent wrt PAGE_SHIFT vs
 PAGE_SIZE in tlb flush code

On Mon, May 22, 2017 at 4:24 PM, Nadav Amit <nadav.amit@...il.com> wrote:
>>
>>       /* Balance as user space task's flush, a bit conservative */
>>       if (end == TLB_FLUSH_ALL ||
>> -         (end - start) > tlb_single_page_flush_ceiling * PAGE_SIZE) {
>> +         (end - start) > tlb_single_page_flush_ceiling >> PAGE_SHIFT) {
>
> Shouldn’t it be << ?

Gah, that's embarrassing.