linux-kernel - Re: [PATCH] mfd: ipaq-micro: dump debugging hexdumps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 22 May 2017 11:48:05 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: ipaq-micro: dump debugging hexdumps

On Mon, 15 May 2017, Linus Walleij wrote:

> These hexdumps get printed no matter if CONFIG_DEBUG is set or
> not. Just get rid of them.
> 
> Signed-off-by: Linus Walleij <linus.walleij@...aro.org>
> ---
>  drivers/mfd/ipaq-micro.c | 5 -----
>  1 file changed, 5 deletions(-)

Applied, thanks.

> diff --git a/drivers/mfd/ipaq-micro.c b/drivers/mfd/ipaq-micro.c
> index 124aad2b1d02..cd762d08f116 100644
> --- a/drivers/mfd/ipaq-micro.c
> +++ b/drivers/mfd/ipaq-micro.c
> @@ -53,8 +53,6 @@ static void ipaq_micro_trigger_tx(struct ipaq_micro *micro)
>  	tx->buf[bp++] = checksum;
>  	tx->len = bp;
>  	tx->index = 0;
> -	print_hex_dump_debug("data: ", DUMP_PREFIX_OFFSET, 16, 1,
> -			     tx->buf, tx->len, true);
>  
>  	/* Enable interrupt */
>  	val = readl(micro->base + UTCR3);
> @@ -281,9 +279,6 @@ static void __init ipaq_micro_eeprom_dump(struct ipaq_micro *micro)
>  	dev_info(micro->dev, "RAM size: %u KiB\n", ipaq_micro_to_u16(dump+92));
>  	dev_info(micro->dev, "screen: %u x %u\n",
>  		 ipaq_micro_to_u16(dump+94), ipaq_micro_to_u16(dump+96));
> -	print_hex_dump_debug("eeprom: ", DUMP_PREFIX_OFFSET, 16, 1,
> -			     dump, 256, true);
> -
>  }
>  
>  static void micro_tx_chars(struct ipaq_micro *micro)

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog