linux-kernel - Re: [PATCH 6/7] perf report: mark inlined frames in output by " (inlined)" suffix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170522124818.GE20009@sejong>
Date:   Mon, 22 May 2017 21:48:18 +0900
From:   Namhyung Kim <namhyung@...nel.org>
To:     Milian Wolff <milian.wolff@...b.com>
Cc:     Linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org,
        Arnaldo Carvalho de Melo <acme@...hat.com>,
        David Ahern <dsahern@...il.com>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        Yao Jin <yao.jin@...ux.intel.com>, kernel-team@....com
Subject: Re: [PATCH 6/7] perf report: mark inlined frames in output by "
 (inlined)" suffix

On Thu, May 18, 2017 at 09:34:10PM +0200, Milian Wolff wrote:
> The original patch that introduced inline frame output in the
> various browsers used this suffix already. The new centralized
> approach that uses fake symbols for inlined frames was missing
> this approach so far.
> 
> Instead of changing the symbol name itself, we only print the
> suffix where needed. This allows us to efficiently lookup
> the symbol for a given name without first having to append the
> suffix before the lookup.

You also need to do same thing for hist_entry__sym_snprintf().

Thanks,
Namhyung


> 
> Cc: Arnaldo Carvalho de Melo <acme@...hat.com>
> Cc: David Ahern <dsahern@...il.com>
> Cc: Namhyung Kim <namhyung@...nel.org>
> Cc: Peter Zijlstra <a.p.zijlstra@...llo.nl>
> Cc: Yao Jin <yao.jin@...ux.intel.com>
> Signed-off-by: Milian Wolff <milian.wolff@...b.com>
> ---
>  tools/perf/util/callchain.c | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/perf/util/callchain.c b/tools/perf/util/callchain.c
> index 211ed3713fac..4350c7ceaca1 100644
> --- a/tools/perf/util/callchain.c
> +++ b/tools/perf/util/callchain.c
> @@ -1061,11 +1061,15 @@ char *callchain_list__sym_name(struct callchain_list *cl,
>  	int printed;
>  
>  	if (cl->ms.sym) {
> +		const char *inlined = cl->ms.sym->inlined ? " (inlined)" : "";
> +
>  		if (show_srcline && cl->srcline)
> -			printed = scnprintf(bf, bfsize, "%s %s",
> -					cl->ms.sym->name, cl->srcline);
> +			printed = scnprintf(bf, bfsize, "%s %s%s",
> +					    cl->ms.sym->name, cl->srcline,
> +					    inlined);
>  		else
> -			printed = scnprintf(bf, bfsize, "%s", cl->ms.sym->name);
> +			printed = scnprintf(bf, bfsize, "%s%s",
> +					    cl->ms.sym->name, inlined);
>  	} else
>  		printed = scnprintf(bf, bfsize, "%#" PRIx64, cl->ip);
>  
> -- 
> 2.13.0
>