linux-kernel - Re: [PATCH 7/7] perf script: mark inlined frames and do not print DSO for them

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7013619.t0f2M9KGuJ@milian-kdab2>
Date:   Wed, 24 May 2017 13:40:56 +0200
From:   Milian Wolff <milian.wolff@...b.com>
To:     Namhyung Kim <namhyung@...nel.org>
Cc:     Linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org,
        Arnaldo Carvalho de Melo <acme@...hat.com>,
        David Ahern <dsahern@...il.com>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        Yao Jin <yao.jin@...ux.intel.com>, kernel-team@....com
Subject: Re: [PATCH 7/7] perf script: mark inlined frames and do not print DSO for them

On Monday, May 22, 2017 2:11:58 PM CEST Namhyung Kim wrote:
> On Thu, May 18, 2017 at 09:34:11PM +0200, Milian Wolff wrote:
> > Instead of showing the (repeated) DSO name of the non-inlined
> > frame, we now show the "(inlined)" suffix instead.
> > 
> > Before:
> >                    214f7 __hypot_finite (/usr/lib/libm-2.25.so)
> >                    
> >                     ace3 hypot (/usr/lib/libm-2.25.so)
> >                     
> >                          std::__complex_abs
> >                          (/home/milian/projects/src/perf-tests/inlining)
> >                          std::abs<double>
> >                          (/home/milian/projects/src/perf-tests/inlining)
> >                          std::_Norm_helper<true>::_S_do_it<double>
> >                          (/home/milian/projects/src/perf-tests/inlining)
> >                          std::norm<double>
> >                          (/home/milian/projects/src/perf-tests/inlining)
> >                      
> >                      a4a main
> >                      (/home/milian/projects/src/perf-tests/inlining)
> >                    
> >                    20510 __libc_start_main (/usr/lib/libc-2.25.so)
> >                    
> >                      bd9 _start
> >                      (/home/milian/projects/src/perf-tests/inlining)
> > 
> > After:
> >                    214f7 __hypot_finite (/usr/lib/libm-2.25.so)
> >                    
> >                     ace3 hypot (/usr/lib/libm-2.25.so)
> >                     
> >                          std::__complex_abs (inlined)
> >                          std::abs<double> (inlined)
> >                          std::_Norm_helper<true>::_S_do_it<double>
> >                          (inlined)
> >                          std::norm<double> (inlined)
> 
> Shouldn't they have 'a4a' too?

Yes, I think I forgot to update the commit message after I changed the 
behavior to keep compatibility with stackcollapse-perf.pl.

Will update the message.

Thanks

-- 
Milian Wolff | milian.wolff@...b.com | Software Engineer
KDAB (Deutschland) GmbH&Co KG, a KDAB Group company
Tel: +49-30-521325470
KDAB - The Qt Experts
Download attachment "smime.p7s" of type "application/pkcs7-signature" (3826 bytes)