linux-kernel - Re: [PATCH 5/6] ubifs: Implement export

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 23 May 2017 01:48:18 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Richard Weinberger <richard@....at>
Cc:     Christoph Hellwig <hch@...radead.org>,
        linux-mtd@...ts.infradead.org, david@...ma-star.at,
        dedekind1@...il.com, adrian.hunter@...el.com,
        linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        adilger.kernel@...ger.ca, akpm@...ux-foundation.org,
        linux-ext4@...r.kernel.org, bfields@...hat.com,
        marcus.folkesson@...il.com, hyc.lee@...il.com,
        rockdotlee@...il.com, leon.pollak@...il.com
Subject: Re: [PATCH 5/6] ubifs: Implement export_operations

On Tue, May 23, 2017 at 10:41:16AM +0200, Richard Weinberger wrote:
> UBIFS has no inode generations, inodes simply can't wrap around.
> We "handle" it like JFF2 does, we assumes that the NAND is long dead
> before we reach the maximum inode number.

So you never ever reuse an inode number once it's been unlinked and
the last opener went away?

If that is the case please add a comment explaining this next to
the get_inode helper.