linux-kernel - Re: [PATCH 5/6] ubifs: Implement export

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d3501e43-07c7-5e11-7057-dfee8b619caf@nod.at>
Date:   Tue, 23 May 2017 10:50:14 +0200
From:   Richard Weinberger <richard@....at>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     linux-mtd@...ts.infradead.org, david@...ma-star.at,
        dedekind1@...il.com, adrian.hunter@...el.com,
        linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        adilger.kernel@...ger.ca, akpm@...ux-foundation.org,
        linux-ext4@...r.kernel.org, bfields@...hat.com,
        marcus.folkesson@...il.com, hyc.lee@...il.com,
        rockdotlee@...il.com, leon.pollak@...il.com
Subject: Re: [PATCH 5/6] ubifs: Implement export_operations

Christoph,

Am 23.05.2017 um 10:48 schrieb Christoph Hellwig:
> On Tue, May 23, 2017 at 10:41:16AM +0200, Richard Weinberger wrote:
>> UBIFS has no inode generations, inodes simply can't wrap around.
>> We "handle" it like JFF2 does, we assumes that the NAND is long dead
>> before we reach the maximum inode number.
> 
> So you never ever reuse an inode number once it's been unlinked and
> the last opener went away?

Correct.

> If that is the case please add a comment explaining this next to
> the get_inode helper.

Will do.

Thanks,
//richard