linux-kernel - Re: [PATCH v4 00/10] Introduce new mode validation callbacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <95ba623b-fe15-2622-3104-46463118d96d@synopsys.com>
Date:   Tue, 23 May 2017 15:40:24 +0100
From:   Jose Abreu <Jose.Abreu@...opsys.com>
To:     Daniel Vetter <daniel@...ll.ch>
CC:     Jose Abreu <Jose.Abreu@...opsys.com>,
        <dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>,
        Carlos Palminha <CARLOS.PALMINHA@...opsys.com>,
        Alexey Brodkin <Alexey.Brodkin@...opsys.com>,
        Ville Syrjälä <ville.syrjala@...ux.intel.com>,
        Dave Airlie <airlied@...ux.ie>,
        Andrzej Hajda <a.hajda@...sung.com>,
        Archit Taneja <architt@...eaurora.org>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>
Subject: Re: [PATCH v4 00/10] Introduce new mode validation callbacks

Hi Daniel,


On 22-05-2017 16:31, Daniel Vetter wrote:
> On Mon, May 22, 2017 at 09:56:00AM +0200, Daniel Vetter wrote:
>> On Fri, May 19, 2017 at 01:52:09AM +0100, Jose Abreu wrote:
>>> This series is a follow up from the discussion at [1]. We start by
>>> introducing crtc->mode_valid(), encoder->mode_valid() and
>>> bridge->mode_valid() callbacks which will be used in followup
>>> patches and also by cleaning the documentation a little bit. This
>>> patch is available at [2] and the series depends on it.
>>>
>>> We proceed by introducing new helpers to call this new callbacks
>>> at 1/10.
>>>
>>> At 2/10 a helper function is introduced that calls all mode_valid()
>>> from a set of bridges.
>>>
>>> Next, at 3/10 we modify the connector probe helper so that only modes
>>> which are supported by a given bridge+encoder+crtc combination are
>>> probbed.
>>>
>>> At 4/10 we call all the mode_valid() callbacks for a given pipeline,
>>> except the connector->mode_valid one, so that the mode is validated.
>>> This is done before calling mode_fixup().
>>>
>>> Finally, from 5/10 to 10/10 we use the new callbacks in drivers that
>>> can implement it.
>>>
>>> [1] https://urldefense.proofpoint.com/v2/url?u=https-3A__patchwork.kernel.org_patch_9702233_&d=DwIBAg&c=DPL6_X_6JkXFx7AXWqB0tg&r=WHDsc6kcWAl4i96Vm5hJ_19IJiuxx_p_Rzo2g-uHDKw&m=YohmJizS2YWha2kjTAHGImBe-ghyCyY_4jKYalIhqcU&s=mtXW7k5AwOp9H790Zg-U0ZB_OXCyW-SRQD9H5kTX5Ec&e= 
>>> [2] https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.freedesktop.org_archives_dri-2Ddevel_2017-2DMay_141761.html&d=DwIBAg&c=DPL6_X_6JkXFx7AXWqB0tg&r=WHDsc6kcWAl4i96Vm5hJ_19IJiuxx_p_Rzo2g-uHDKw&m=YohmJizS2YWha2kjTAHGImBe-ghyCyY_4jKYalIhqcU&s=N3-YUnWxQAD9jw0y7xFB0fAuCGa_B6Q6yRsL2OmGWM0&e= 
>>>
>>> Jose Abreu (10):
>>>   drm: Add drm_{crtc/encoder/connector}_mode_valid()
>>>   drm: Introduce drm_bridge_mode_valid()
>>>   drm: Use new mode_valid() helpers in connector probe helper
>>>   drm: Use mode_valid() in atomic modeset
>>>   drm: arc: Use crtc->mode_valid() callback
>>>   drm/bridge: analogix-anx78xx: Use bridge->mode_valid() callback
>>>   drm/bridge/synopsys: dw-hdmi: Use bridge->mode_valid() callback
>>>   drm/arm: malidp: Use crtc->mode_valid() callback
>>>   drm/atmel-hlcdc: Use crtc->mode_valid() callback
>>>   drm: vc4: Use crtc->mode_valid() and encoder->mode_valid() callbacks
>> Looks all real nice, I think a bit more time to get acks/reviews/tested-by
>> for the driver conversions and I'll go and vacuum this all up.
> On that: You didn't cc driver maintainers on the driver conversion patches
> (not all are bridge drivers maintainer by Archit&co), without that they
> might miss it. Please remember to do that (you might need to resend to get
> their attention), scripts/get_maintainers.pl helps with that.

Yeah, I'm really sorry about that. I was in a different time zone
with all my head messed up with jetlag so I missed this and maybe
more :/ Lets wait for some input and I will resend the series if
needed.

Thanks!

Best regards,
Jose Miguel Abreu

>
> Thanks, Daniel