linux-kernel - Re: [PATCH v5 0/2] Add PCIe host driver support for Mediatek SoCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170524215641.GE2794@bhelgaas-glaptop.roam.corp.google.com>
Date:   Wed, 24 May 2017 16:56:41 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Ryder Lee <ryder.lee@...iatek.com>
Cc:     Bjorn Helgaas <bhelgaas@...gle.com>,
        Rob Herring <robh+dt@...nel.org>,
        Arnd Bergmann <arnd@...db.de>, devicetree@...r.kernel.org,
        Red Hung <red.hung@...iatek.com>, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-mediatek@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v5 0/2] Add PCIe host driver support for Mediatek SoCs

On Sun, May 21, 2017 at 11:42:23AM +0800, Ryder Lee wrote:
> Hi,
> 
> This patch series add Mediatek Gen2 PCIe host controller driver and
> dt-binding document. It can be found on MT7623 series SoCs.
> 
> This driver was validated using Broadcom Tigon3 and Intel(R) 82575/82576
> gigabit ethernet card.
> 
> 
> Changes since v5:
> - rebase to Linux 4.12-rc1.
> - remove redundant module.h header and MODULE macros.
> 
> Changes since v4:
> - move the per-port registers to the parent node.
> - use a valid compatible for hifsys controller.
> - use the 'sysirq' instead of 'gic' as a correct 'interrupt-parent' of the
>   interrupt-map properties.
> 
>   'sysirq' is an interrupt-controller that could help us to reverse GIC SPIs polarity
>   so that we could properly set irq type to level low without any extra properties.
>   It was a mistake to select wrong interrupt-parent on the previous versions.
>   Now, we could remove unnecessary interrupt properties entirely from binding.
> 
> Changes since v3:
> - correct sub-nodes unit addresses.
> 
> Changes since v2:
> - modify Kconfig to avoid kbuild test error on some architecture.
> - change compatible string.
> - revise binding document:
>   add missing interrupt-names.
>   remove the board dts example and drop 'status' properties.
>   remove unnecessary descriptions bout standard PCI bus binding.
> 
> Changes since v1:
> - add .suppress_bind_attrs.
> - remove unnecessary *_valid_device() pattern.
> - remove PCI_PROBE_ONLY.
> - use the regular readl() instead of readl_relaxed().
> - add .map_bus() and change to use pci_generic_config_read/pci_generic_config_write.
> - revise dt-binding document and move nonstandard properties to root node.
> - change compatible string.
> - use interrupt-map property and replace mtk_pcie_map_irq() with of_irq_parse_and_map_pci().
> - use the new pci_register_host_bridge() method instead of pci_scan_root_bus()*
> 
> Ryder Lee (2):
>   PCI: mediatek: Add Mediatek PCIe host controller support
>   dt-bindings: pcie: Add documentation for Mediatek PCIe
> 
>  .../bindings/pci/mediatek,mt7623-pcie.txt          | 130 +++++
>  drivers/pci/host/Kconfig                           |  11 +
>  drivers/pci/host/Makefile                          |   1 +
>  drivers/pci/host/pcie-mediatek.c                   | 553 +++++++++++++++++++++
>  4 files changed, 695 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/pci/mediatek,mt7623-pcie.txt
>  create mode 100644 drivers/pci/host/pcie-mediatek.c

Applied to pci/host-mediatek for v4.13, thanks!