[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20170628195325.GR17844@bhelgaas-glaptop.roam.corp.google.com>
Date: Wed, 28 Jun 2017 14:53:26 -0500
From: Bjorn Helgaas <helgaas@...nel.org>
To: Ryder Lee <ryder.lee@...iatek.com>
Cc: Bjorn Helgaas <bhelgaas@...gle.com>,
Rob Herring <robh+dt@...nel.org>,
Arnd Bergmann <arnd@...db.de>, devicetree@...r.kernel.org,
Red Hung <red.hung@...iatek.com>, linux-pci@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-mediatek@...ts.infradead.org,
linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v5 1/2] PCI: mediatek: Add Mediatek PCIe host controller
support
On Sun, May 21, 2017 at 11:42:24AM +0800, Ryder Lee wrote:
> Add support for the Mediatek PCIe Gen2 controller which can
> be found on MT7623 series SoCs.
>
> Signed-off-by: Ryder Lee <ryder.lee@...iatek.com>
> ---
> drivers/pci/host/Kconfig | 11 +
> drivers/pci/host/Makefile | 1 +
> drivers/pci/host/pcie-mediatek.c | 553 +++++++++++++++++++++++++++++++++++++++
> 3 files changed, 565 insertions(+)
> create mode 100644 drivers/pci/host/pcie-mediatek.c
>...
> +static int mtk_pcie_register_host(struct pci_host_bridge *host)
> +{
> + struct mtk_pcie *pcie = pci_host_bridge_priv(host);
> + struct pci_bus *child;
> + int err;
> +
> + pci_add_flags(PCI_REASSIGN_ALL_RSRC | PCI_REASSIGN_ALL_BUS);
Do you really need the PCI_REASSIGN_ALL_RSRC and PCI_REASSIGN_ALL_BUS
flags? I'd like to get rid of them because we should automatically
assign resources if the firmware hasn't done it.
Bjorn
Powered by blists - more mailing lists