linux-kernel - Re: [PATCH v1] PM / devfreq: exynos-nocp : Handle return value of clk_prepare

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <5924E865.6030105@samsung.com>
Date:   Wed, 24 May 2017 10:56:53 +0900
From:   Chanwoo Choi <cw00.choi@...sung.com>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>, myungjoo.ham@...sung.com,
        kyungmin.park@...sung.com, krzk@...nel.org, kgene@...nel.org,
        javier@....samsung.com
Cc:     linux-pm@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] PM / devfreq: exynos-nocp : Handle return value of
 clk_prepare_enable

On 2017년 05월 23일 18:43, Chanwoo Choi wrote:
> Hi Arvind,
> 
> On 2017년 05월 19일 19:50, Arvind Yadav wrote:
>> clk_prepare_enable() can fail here and we must check its return value.
>>
>> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
>> ---
>>  drivers/devfreq/event/exynos-nocp.c | 6 +++++-
>>  1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/devfreq/event/exynos-nocp.c b/drivers/devfreq/event/exynos-nocp.c
>> index 5c3e7b1..f6e7956 100644
>> --- a/drivers/devfreq/event/exynos-nocp.c
>> +++ b/drivers/devfreq/event/exynos-nocp.c
>> @@ -267,7 +267,11 @@ static int exynos_nocp_probe(struct platform_device *pdev)
>>  	}
>>  	platform_set_drvdata(pdev, nocp);
>>  
>> -	clk_prepare_enable(nocp->clk);
>> +	ret = clk_prepare_enable(nocp->clk);
>> +	if (ret) {
>> +		dev_err(&pdev->dev, "failed to prepare ppmu clock\n");
>> +		return ret;
>> +	}
> 
> I already replied from the similar patch. Thanks.
> 
>>  
>>  	pr_info("exynos-nocp: new NoC Probe device registered: %s\n",
>>  			dev_name(dev));
>>
> 
> 

I'm missing some point that if there is no clock
this driver initializes 'nocp->clk = NULL;' on 217 line.

Looks good to me.
Acked-by: Chanwoo Choi <cw00.choi@...sung.com>

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics