linux-kernel - Re: [PATCH 1/2] scsi: nsp32: add __printf attribute to logging functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <yq11srfxba8.fsf@oracle.com>
Date:   Tue, 23 May 2017 22:02:07 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Joe Perches <joe@...ches.com>
Cc:     Nicolas Iooss <nicolas.iooss_linux@....org>,
        GOTO Masanori <gotom@...ian.or.jp>,
        YOKOTA Hiroshi <yokota@...lab.is.tsukuba.ac.jp>,
        "James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] scsi: nsp32: add __printf attribute to logging functions


Joe,

> On Sat, 2017-05-20 at 13:16 +0200, Nicolas Iooss wrote:
>> nsp32_message() and nsp32_dmessage() use printf format strings in order
>> to format a message. Adding __printf attributes helps to detect errors
>> in such format strings at build time, like:

> Does anyone actually have or use these cards any longer?

I doubt it.

-- 
Martin K. Petersen	Oracle Linux Engineering