[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <796029e7-60a3-a94b-8b5c-4686a0656560@users.sourceforge.net>
Date: Wed, 24 May 2017 20:15:14 +0200
From: SF Markus Elfring <elfring@...rs.sourceforge.net>
To: Manuel Lauss <manuel.lauss@...il.com>, linux-mips@...ux-mips.org
Cc: Paul Burton <paul.burton@...tec.com>,
Ralf Bächle <ralf@...ux-mips.org>,
LKML <linux-kernel@...r.kernel.org>,
kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] MIPS: Alchemy: Delete an error message for a failed
memory allocation in alchemy_pci_probe()
>> +++ b/arch/mips/pci/pci-alchemy.c
>> @@ -377,7 +377,6 @@ static int alchemy_pci_probe(struct platform_device *pdev)
>>
>> ctx = kzalloc(sizeof(*ctx), GFP_KERNEL);
>> if (!ctx) {
>> - dev_err(&pdev->dev, "no memory for pcictl context\n");
>> ret = -ENOMEM;
>> goto out;
>> }
>> --
>> 2.13.0
>
> Why are you removing just this one dev_err()?
How do you think about to achieve a small code reduction also for this software module?
> What issue are you trying to address?
Do you find information from a Linux allocation failure report sufficient
for such a function implementation?
Regards,
Markus
Powered by blists - more mailing lists