linux-kernel - Re: [PATCH] MIPS: Alchemy: Delete an error message for a failed memory allocation in alchemy_pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <98579b27-3052-0300-ec67-84f75f761a35@infradead.org>
Date:   Wed, 24 May 2017 11:26:00 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     SF Markus Elfring <elfring@...rs.sourceforge.net>,
        Manuel Lauss <manuel.lauss@...il.com>,
        linux-mips@...ux-mips.org
Cc:     Paul Burton <paul.burton@...tec.com>,
        Ralf Bächle <ralf@...ux-mips.org>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] MIPS: Alchemy: Delete an error message for a failed
 memory allocation in alchemy_pci_probe()

On 05/24/17 11:15, SF Markus Elfring wrote:
>>> +++ b/arch/mips/pci/pci-alchemy.c
>>> @@ -377,7 +377,6 @@ static int alchemy_pci_probe(struct platform_device *pdev)
>>>
>>>         ctx = kzalloc(sizeof(*ctx), GFP_KERNEL);
>>>         if (!ctx) {
>>> -               dev_err(&pdev->dev, "no memory for pcictl context\n");
>>>                 ret = -ENOMEM;
>>>                 goto out;
>>>         }
>>> --
>>> 2.13.0
>>
>> Why are you removing just this one dev_err()?

Agreed.  Why just this one error message when there are many in this function?

> How do you think about to achieve a small code reduction also for this software module?
> 
> 
>> What issue are you trying to address?
> 
> Do you find information from a Linux allocation failure report sufficient
> for such a function implementation?

Can you answer questions with statements instead of with questions?

thanks.
-- 
~Randy