linux-kernel - Re: [PATCH 2/2] timer: imx-tpm: add imx tpm timer support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a1JEzZFn4FXi2tb2jOFtV-3MRD-7O3gPBiZDM4qc3BTnA@mail.gmail.com>
Date:   Thu, 25 May 2017 23:02:22 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Dong Aisheng <aisheng.dong@....com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Shawn Guo <shawnguo@...nel.org>, ping.bai@....com,
        anson.huang@....com, dongas86@...il.com,
        Sascha Hauer <kernel@...gutronix.de>
Subject: Re: [PATCH 2/2] timer: imx-tpm: add imx tpm timer support

On Sat, May 13, 2017 at 9:29 AM, Dong Aisheng <aisheng.dong@....com> wrote:

> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> index 3356ab8..03dfd6a 100644
> --- a/drivers/clocksource/Kconfig
> +++ b/drivers/clocksource/Kconfig
> @@ -590,6 +590,11 @@ config CLKSRC_IMX_GPT
>         depends on ARM && CLKDEV_LOOKUP
>         select CLKSRC_MMIO
>
> +config CLKSRC_IMX_TPM
> +       bool "Clocksource using i.MX TPM" if COMPILE_TEST
> +       depends on ARM && CLKDEV_LOOKUP && GENERIC_CLOCKEVENTS
> +       select CLKSRC_MMIO
> +

This needs a help text


> +static inline void tpm_timer_disable(void)
> +{
> +       unsigned int val;
> +
> +       /* channel disable */
> +       val = __raw_readl(timer_base + TPM_C0SC);
> +       val &= ~(TPM_C0SC_MODE_MASK | TPM_C0SC_CHIE);
> +       __raw_writel(val, timer_base + TPM_C0SC);
> +}

__raw_readl/__raw_writel is broken on big-endian kernels, please
use readl/writel instead.

        Arnd