linux-kernel - Re: [PATCH 2/2] timer: imx-tpm: add imx tpm timer support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170525205455.GB9501@mai>
Date:   Thu, 25 May 2017 22:54:55 +0200
From:   Daniel Lezcano <daniel.lezcano@...aro.org>
To:     Dong Aisheng <aisheng.dong@....com>
Cc:     linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        tglx@...utronix.de, shawnguo@...nel.org, ping.bai@....com,
        anson.huang@....com, dongas86@...il.com, kernel@...gutronix.de,
        arnd@...db.de
Subject: Re: [PATCH 2/2] timer: imx-tpm: add imx tpm timer support

On Sat, May 13, 2017 at 03:29:35PM +0800, Dong Aisheng wrote:
> IMX Timer/PWM Module (TPM) supports both timer and pwm function while
> this patch only adds the timer support. PWM would be added later.
> 
> The TPM counter, compare and capture registers are clocked by an
> asynchronous clock that can remain enabled in low power modes.
> 
> Cc: Daniel Lezcano <daniel.lezcano@...aro.org>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Shawn Guo <shawnguo@...nel.org>
> Signed-off-by: Anson Huang <Anson.Huang@....com>
> Signed-off-by: Bai Ping <ping.bai@....com>
> Signed-off-by: Dong Aisheng <aisheng.dong@....com>
> ---

[ ... ]

> +	val = __raw_readl(timer_base + TPM_C0SC);
> +	val &= ~(TPM_C0SC_MODE_MASK | TPM_C0SC_CHIE);
> +	__raw_writel(val, timer_base + TPM_C0SC);

Hi Dong,

why are you using __raw_write/__raw_read instead of regular readl/writel?