linux-kernel - Re: [PATCH 2/2] crypto: mediatek - update DT binding documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 26 May 2017 16:15:23 +0200
From:   Matthias Brugger <matthias.bgg@...il.com>
To:     Ryder Lee <ryder.lee@...iatek.com>,
        Herbert Xu <herbert@...dor.apana.org.au>
Cc:     devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Rob Herring <robh+dt@...nel.org>,
        linux-mediatek@...ts.infradead.org, linux-crypto@...r.kernel.org
Subject: Re: [PATCH 2/2] crypto: mediatek - update DT binding documentation



On 26/05/17 11:43, Ryder Lee wrote:
> This patch removes unnecessary clock in binding file.
> 
> Signed-off-by: Ryder Lee <ryder.lee@...iatek.com>
> ---

In the driver clocks are get by name, so this change does not break 
backwards compatibility.

Reviewed-by: Matthias Brugger <matthias.bgg@...il.com>

>   Documentation/devicetree/bindings/crypto/mediatek-crypto.txt | 8 +++-----
>   1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/crypto/mediatek-crypto.txt b/Documentation/devicetree/bindings/crypto/mediatek-crypto.txt
> index c204725..450da36 100644
> --- a/Documentation/devicetree/bindings/crypto/mediatek-crypto.txt
> +++ b/Documentation/devicetree/bindings/crypto/mediatek-crypto.txt
> @@ -6,8 +6,7 @@ Required properties:
>   - interrupts: Should contain the five crypto engines interrupts in numeric
>   	order. These are global system and four descriptor rings.
>   - clocks: the clock used by the core
> -- clock-names: the names of the clock listed in the clocks property. These are
> -	"ethif", "cryp"
> +- clock-names: Must contain "cryp".
>   - power-domains: Must contain a reference to the PM domain.
>   
>   
> @@ -20,8 +19,7 @@ Example:
>   			     <GIC_SPI 84 IRQ_TYPE_LEVEL_LOW>,
>   			     <GIC_SPI 91 IRQ_TYPE_LEVEL_LOW>,
>   			     <GIC_SPI 97 IRQ_TYPE_LEVEL_LOW>;
> -		clocks = <&topckgen CLK_TOP_ETHIF_SEL>,
> -			 <&ethsys CLK_ETHSYS_CRYPTO>;
> -		clock-names = "ethif","cryp";
> +		clocks = <&ethsys CLK_ETHSYS_CRYPTO>;
> +		clock-names = "cryp";
>   		power-domains = <&scpsys MT2701_POWER_DOMAIN_ETH>;
>   	};
>