linux-kernel - Re: [PATCH] scsi: lpfc: prevent potential null pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5e0120e9-418d-c051-cd3e-03c39ff8f627@broadcom.com>
Date:   Mon, 29 May 2017 16:06:28 -0700
From:   James Smart <james.smart@...adcom.com>
To:     "Gustavo A. R. Silva" <garsilva@...eddedor.com>,
        Dick Kennedy <dick.kennedy@...adcom.com>,
        "James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>
Cc:     linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: lpfc: prevent potential null pointer dereference

Looks good

Signed-off-by: James Smart <james.smart@...adcom.com>

-- james


On 5/23/2017 8:09 AM, Gustavo A. R. Silva wrote:
> Null check at line 966: if (ndlp) {,  implies that ndlp might be NULL.
> Functions lpfc_nlp_set_state() and lpfc_issue_els_prli() dereference
> pointer ndlp. Include these function calls inside the IF block that
> tests pointer ndlp.
>
> Addresses-Coverity-ID: 1401856
>