linux-kernel - Re: [PATCH] scsi: lpfc: make a couple of functions static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3d1696a8-0f7b-20aa-b242-839b91cc7068@broadcom.com>
Date:   Mon, 29 May 2017 16:08:47 -0700
From:   James Smart <james.smart@...adcom.com>
To:     Colin King <colin.king@...onical.com>,
        Dick Kennedy <dick.kennedy@...adcom.com>,
        "James E . J . Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K . Petersen" <martin.petersen@...cle.com>,
        linux-scsi@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: lpfc: make a couple of functions static

Patch is fine.

Signed-off-by: James Smart  <james.smart@...adcom.com>

-- james


On 5/18/2017 2:35 AM, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
>
> functions lpfc_nvmet_cleanup_io_context and lpfc_nvmet_setup_io_context
> can be made static as they do not need to be in global scope.
>
> Cleans up sparse warnings:
>    "warning: symbol 'lpfc_nvmet_cleanup_io_context' was not declared.
>     Should it be static?"
>    "warning: symbol 'lpfc_nvmet_setup_io_context' was not declared.
>     Should it be static?"
>
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
>