linux-kernel - Re: [PATCH] ALSA: declare snd_kcontrol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hr2z6emya.wl-tiwai@suse.de>
Date:   Tue, 30 May 2017 11:03:09 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Julia Lawall <julia.lawall@...6.fr>
Cc:     Bhumika Goyal <bhumirks@...il.com>, alsa-devel@...a-project.org,
        lgirdwood@...il.com, broonie@...nel.org, clemens@...isch.de,
        linuxppc-dev@...ts.ozlabs.org, perex@...ex.cz,
        johannes@...solutions.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: declare snd_kcontrol_new structures as const

On Tue, 30 May 2017 10:56:39 +0200,
Julia Lawall wrote:
> 
> 
> 
> On Tue, 30 May 2017, Takashi Iwai wrote:
> 
> > On Sat, 27 May 2017 16:46:15 +0200,
> > Bhumika Goyal wrote:
> > >
> > > Declare snd_kcontrol_new structures as const as they are only passed an
> > > argument to the function snd_ctl_new1. This argument is of type const,
> > > so snd_kcontrol_new structures having this property can be made const.
> > > Done using Coccinelle:
> > >
> > > @r disable optional_qualifier@
> > > identifier x;
> > > position p;
> > > @@
> > > static struct snd_kcontrol_new x@......};
> > >
> > > @ok@
> > > identifier r.x;
> > > position p;
> > > @@
> > > snd_ctl_new1(&x@p,...)
> > >
> > > @bad@
> > > position p != {r.p,ok.p};
> > > identifier r.x;
> > > @@
> > > x@p
> > >
> > > @depends on !bad disable optional_qualifier@
> > > identifier r.x;
> > > @@
> > > +const
> > > struct snd_kcontrol_new x;
> > >
> > > Cross compiled these files:
> > > sound/aoa/codecs/tas.c - powerpc
> > > sound/mips/{hal2.c/sgio2audio.c} - mips
> > > sound/ppc/{awacs.c/beep.c/tumbler.c} - powerpc
> > > sound/soc/sh/siu_dai.c - sh
> > > Could not find an architecture to compile sound/sh/aica.c.
> > >
> > > Signed-off-by: Bhumika Goyal <bhumirks@...il.com>
> >
> > Applied now, as it looks safe enough.  But I prefer splitting to
> > individual patches, so please try to do that at the next time.
> 
> Individual patches in a series?

Yes.


Takashi