lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 30 May 2017 11:03:24 +0200 From: Geert Uytterhoeven <geert@...ux-m68k.org> To: Linus Walleij <linus.walleij@...aro.org> Cc: Arnd Bergmann <arnd@...db.de>, Paul Cercueil <paul@...pouillou.net>, "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH 1/2] gpio: ingenic: add CONFIG_OF dependency On Mon, May 29, 2017 at 6:45 PM, Linus Walleij <linus.walleij@...aro.org> wrote: > On Mon, May 29, 2017 at 2:57 PM, Arnd Bergmann <arnd@...db.de> wrote: > >> The driver cannot access the of_node field when CONFIG_OF is disabled: >> >> drivers/gpio/gpio-ingenic.c: In function 'ingenic_gpio_probe': >> drivers/gpio/gpio-ingenic.c:324:10: error: 'struct gpio_chip' has no member named 'of_node' >> >> Fixes: b0653ce39a0d ("gpio: Add gpio-ingenic driver") >> Signed-off-by: Arnd Bergmann <arnd@...db.de> > > I already sent a combined patch fixing these two deps earlier today, > good that we are several at it :) Hmm... issues like these are actually the reasons why the of_node member of struct device does not depend on CONFIG_OF? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Powered by blists - more mailing lists