linux-kernel - Re: [PATCH 1/2] gpio: ingenic: add CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdY9eBh0fe_G+a=8XqtNTVyYLJQfh1XJGxDzEwx5XqrneQ@mail.gmail.com>
Date:   Tue, 30 May 2017 11:57:18 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Paul Cercueil <paul@...pouillou.net>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] gpio: ingenic: add CONFIG_OF dependency

On Tue, May 30, 2017 at 11:03 AM, Geert Uytterhoeven
<geert@...ux-m68k.org> wrote:
> On Mon, May 29, 2017 at 6:45 PM, Linus Walleij <linus.walleij@...aro.org> wrote:
>> On Mon, May 29, 2017 at 2:57 PM, Arnd Bergmann <arnd@...db.de> wrote:
>>
>>> The driver cannot access the of_node field when CONFIG_OF is disabled:
>>>
>>> drivers/gpio/gpio-ingenic.c: In function 'ingenic_gpio_probe':
>>> drivers/gpio/gpio-ingenic.c:324:10: error: 'struct gpio_chip' has no member named 'of_node'
>>>
>>> Fixes: b0653ce39a0d ("gpio: Add gpio-ingenic driver")
>>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>>
>> I already sent a combined patch fixing these two deps earlier today,
>> good that we are several at it :)
>
> Hmm... issues like these are actually the reasons why the of_node member
> of struct device does not depend on CONFIG_OF?

It's a bit of kludginess-vs-footprint thing I guess, you gain a pointer,
you loose a bit of Kconfig and #ifdefs.

Yours,
Linus Walleij