linux-kernel - Re: [PATCH v2] net: don't call strlen on non-terminated string in dev_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170531083706.1baa729f@xeon-e3>
Date:   Wed, 31 May 2017 08:37:06 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Alexander Potapenko <glider@...gle.com>
Cc:     dvyukov@...gle.com, kcc@...gle.com, edumazet@...gle.com,
        davem@...emloft.net, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH v2] net: don't call strlen on non-terminated string in
 dev_set_alias()

On Wed, 31 May 2017 14:51:50 +0200
Alexander Potapenko <glider@...gle.com> wrote:

> +	/* alias comes from the userspace and may not be zero-terminated.
> +	 */
> +	memcpy(dev->ifalias, alias, len);

You don't need a multi-line comment here.