linux-kernel - Re: [PATCH v3 14/23] scsi: hisi_sas: add v3 cq interrupt handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <04821e06-7541-1861-d52b-4df869570ca7@huawei.com>
Date:   Thu, 1 Jun 2017 11:36:55 +0100
From:   John Garry <john.garry@...wei.com>
To:     Christoph Hellwig <hch@...radead.org>
CC:     <jejb@...ux.vnet.ibm.com>, <martin.petersen@...cle.com>,
        <john.garry2@...l.dcu.ie>, <linuxarm@...wei.com>,
        <linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <arnd@...db.de>, Xiang Chen <chenxiang66@...ilicon.com>
Subject: Re: [PATCH v3 14/23] scsi: hisi_sas: add v3 cq interrupt handler

On 01/06/2017 06:41, Christoph Hellwig wrote:
>> +	case SAS_PROTOCOL_SSP:
>> +	{
>> +		unsigned char op = task->ssp_task.cmd->cmnd[0];
>> +
>> +		if (op == READ_6 || op == WRITE_6 ||
>> +			op == READ_10 || op == WRITE_10 ||
>> +			op == READ_12 || op == WRITE_12 ||
>> +			op == READ_16 || op == WRITE_16)
>> +			return true;
>> +		break;
>> +	}
>
> Wee. why do you care?  >

In the command completion code we need to check for abnormal completion 
due to underflow, but ignore it when it occurs in some commands, like 
inquiry. This is why we check for rw command - it is equivalent to !inquiry.

I'll see if we can change the check to explicitly ignore certain 
commands which complete abnormally with underflow.

>What about 32-byte CDs or things like Write Same?
>

You're talking about VARIABLE_LENGTH_CMD (opcode 0x7f) for 32-byte CDs, 
right?

I need to check on WRITE SAME.

> .
>

Thanks,
John