linux-kernel - Re: [PATCH 1/3] staging: typec: Fix one defect of incorrect type in argument.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170601145714.bjsywgifv2vxaa3o@mwanda>
Date:   Thu, 1 Jun 2017 17:57:14 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     ? ? <incarnation.p.lee@...look.com>
Cc:     "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "linux@...ck-us.net" <linux@...ck-us.net>,
        "yueyao.zhu@...il.com" <yueyao.zhu@...il.com>,
        "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
        "o_leveque@...nge.fr" <o_leveque@...nge.fr>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] staging: typec: Fix one defect of incorrect type in
 argument.

On Thu, Jun 01, 2017 at 07:21:00AM +0000, ? ? wrote:
> From: Pan Li <incarnation.p.lee@...look.com>
> 
>     Convert type le16 to cpu of argument 1 in function pd_header_cnt.
> 
> Signed-off-by: Pan Li <incarnation.p.lee@...look.com>
> ---
>  drivers/staging/typec/tcpci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/typec/tcpci.c b/drivers/staging/typec/tcpci.c
> index df72d8b..405c9cc 100644
> --- a/drivers/staging/typec/tcpci.c
> +++ b/drivers/staging/typec/tcpci.c
> @@ -287,7 +287,7 @@ static int tcpci_pd_transmit(struct tcpc_dev *tcpc,
>  	unsigned int reg, cnt, header;
>  	int ret;
>  
> -	cnt = msg ? pd_header_cnt(msg->header) * 4 : 0;
> +	cnt = msg ? pd_header_cnt(le16_to_cpu(msg->header)) * 4 : 0;

I guess this one is probably correct...

regards,
dan carpenter