linux-kernel - Re: [PATCH 1/3] staging: typec: Fix one defect of incorrect type in argument.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170601151715.GA6820@roeck-us.net>
Date:   Thu, 1 Jun 2017 08:17:15 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     ? ? <incarnation.p.lee@...look.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "yueyao.zhu@...il.com" <yueyao.zhu@...il.com>,
        "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
        "o_leveque@...nge.fr" <o_leveque@...nge.fr>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] staging: typec: Fix one defect of incorrect type in
 argument.

On Thu, Jun 01, 2017 at 05:57:14PM +0300, Dan Carpenter wrote:
> On Thu, Jun 01, 2017 at 07:21:00AM +0000, ? ? wrote:
> > From: Pan Li <incarnation.p.lee@...look.com>
> > 
> >     Convert type le16 to cpu of argument 1 in function pd_header_cnt.
> > 
> > Signed-off-by: Pan Li <incarnation.p.lee@...look.com>
> > ---
> >  drivers/staging/typec/tcpci.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/staging/typec/tcpci.c b/drivers/staging/typec/tcpci.c
> > index df72d8b..405c9cc 100644
> > --- a/drivers/staging/typec/tcpci.c
> > +++ b/drivers/staging/typec/tcpci.c
> > @@ -287,7 +287,7 @@ static int tcpci_pd_transmit(struct tcpc_dev *tcpc,
> >  	unsigned int reg, cnt, header;
> >  	int ret;
> >  
> > -	cnt = msg ? pd_header_cnt(msg->header) * 4 : 0;
> > +	cnt = msg ? pd_header_cnt(le16_to_cpu(msg->header)) * 4 : 0;
> 
> I guess this one is probably correct...
> 
Yes. Overall though the series only touches the surface; the driver as-is is
just not endianness clean. Someone will have to go through it and fix all
problems. For example, tcpci_read16() is flawed since it reads 16 bits into
a unrestricted 32 bit variable pointer. This needs some active work and can
not rely on code analysis to find and fix the all flaws. Something to add
to TODO.

Side note: The subject lines in this series are all messed up.

Thanks,
Guenter