linux-kernel - Re: [PATCH 2/3] staging: typec: Fix one defect of incorrect type assignment.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20170601145856.xjmo5rh7o63itbpz@mwanda>
Date:   Thu, 1 Jun 2017 17:58:56 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     ? ? <incarnation.p.lee@...look.com>
Cc:     "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "linux@...ck-us.net" <linux@...ck-us.net>,
        "yueyao.zhu@...il.com" <yueyao.zhu@...il.com>,
        "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
        "o_leveque@...nge.fr" <o_leveque@...nge.fr>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/3] staging: typec: Fix one defect of incorrect type
 assignment.

On Thu, Jun 01, 2017 at 07:21:22AM +0000, ? ? wrote:
> From: Pan Li <incarnation.p.lee@...look.com>
> 
>     Convert type le16 to cpu for consistent type assignment.
> 
> Signed-off-by: Pan Li <incarnation.p.lee@...look.com>
> ---
>  drivers/staging/typec/tcpci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/typec/tcpci.c b/drivers/staging/typec/tcpci.c
> index 405c9cc..18d2e06 100644
> --- a/drivers/staging/typec/tcpci.c
> +++ b/drivers/staging/typec/tcpci.c
> @@ -292,7 +292,7 @@ static int tcpci_pd_transmit(struct tcpc_dev *tcpc,
>  	if (ret < 0)
>  		return ret;
>  
> -	header = msg ? msg->header : 0;
> +	header = msg ? le16_to_cpu(msg->header) : 0;
>  	ret = tcpci_write16(tcpci, TCPC_TX_HDR, header);

This looks like it introduces bugs.  We normally write endian data and
you've changed it to write CPU endian data.

regards,
dan carpenter