lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 2 Jun 2017 09:28:47 +0200 From: Jan Kiszka <jan.kiszka@...mens.com> To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Linus Walleij <linus.walleij@...aro.org>, Alexandre Courbot <gnurou@...il.com> Cc: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, linux-serial@...r.kernel.org, linux-gpio@...r.kernel.org, Sudip Mukherjee <sudip.mukherjee@...ethink.co.uk>, Andy Shevchenko <andy.shevchenko@...il.com>, Sascha Weisenberger <sascha.weisenberger@...mens.com> Subject: [PATCH v5 04/11] gpio: exar: Allocate resources on behalf of the platform device Do not allocate resources on behalf of the parent device but on our own. Otherwise, cleanup does not properly work if gpio-exar is removed but not the parent device. Signed-off-by: Jan Kiszka <jan.kiszka@...mens.com> Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com> Acked-by: Linus Walleij <linus.walleij@...aro.org> --- drivers/gpio/gpio-exar.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-exar.c b/drivers/gpio/gpio-exar.c index da4550bb9939..65126fa1e512 100644 --- a/drivers/gpio/gpio-exar.c +++ b/drivers/gpio/gpio-exar.c @@ -136,7 +136,7 @@ static int gpio_exar_probe(struct platform_device *pdev) if (!p) return -ENOMEM; - exar_gpio = devm_kzalloc(&pcidev->dev, sizeof(*exar_gpio), GFP_KERNEL); + exar_gpio = devm_kzalloc(&pdev->dev, sizeof(*exar_gpio), GFP_KERNEL); if (!exar_gpio) return -ENOMEM; @@ -157,7 +157,7 @@ static int gpio_exar_probe(struct platform_device *pdev) exar_gpio->regs = p; exar_gpio->index = index; - ret = devm_gpiochip_add_data(&pcidev->dev, + ret = devm_gpiochip_add_data(&pdev->dev, &exar_gpio->gpio_chip, exar_gpio); if (ret) goto err_destroy; -- 2.12.3
Powered by blists - more mailing lists