lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 2 Jun 2017 00:29:48 -0700 From: John Johansen <john.johansen@...onical.com> To: Deepa Dinamani <deepa.kernel@...il.com>, linux-kernel@...r.kernel.org, akpm@...ux-foundation.org Cc: tglx@...utronix.de, viro@...iv.linux.org.uk, gregkh@...uxfoundation.org, andreas.dilger@...el.com, arnd@...db.de, bfields@...ldses.org, clm@...com, davem@...emloft.net, dsterba@...e.com, dushistov@...l.ru, eparis@...hat.com, jaegeuk@...nel.org, jbacik@...com, jlayton@...chiereds.net, john.stultz@...aro.org, jsimmons@...radead.org, mingo@...hat.com, oleg.drokin@...el.com, paul@...l-moore.com, rostedt@...dmis.org, yuchao0@...wei.com, ceph-devel@...r.kernel.org, devel@...verdev.osuosl.org, linux-audit@...hat.com, linux-btrfs@...r.kernel.org, linux-cifs@...r.kernel.org, linux-f2fs-devel@...ts.sourceforge.net, linux-fsdevel@...r.kernel.org, linux-mtd@...ts.infradead.org, linux-security-module@...r.kernel.org, lustre-devel@...ts.lustre.org, netdev@...r.kernel.org, samba-technical@...ts.samba.org, y2038@...ts.linaro.org Subject: Re: [PATCH 10/12] apparmorfs: Replace CURRENT_TIME with current_time() On 04/07/2017 05:57 PM, Deepa Dinamani wrote: > CURRENT_TIME macro is not y2038 safe on 32 bit systems. > > The patch replaces all the uses of CURRENT_TIME by > current_time(). > > This is also in preparation for the patch that transitions > vfs timestamps to use 64 bit time and hence make them > y2038 safe. current_time() is also planned to be transitioned > to y2038 safe behavior along with this change. > > CURRENT_TIME macro will be deleted before merging the > aforementioned change. > > Signed-off-by: Deepa Dinamani <deepa.kernel@...il.com> This is all good, and I have no objections to it being merged for 4.12. If it isn't this change is already queued up for the apparmor 4.13 merge Acked-by: John Johansen <john.johansen@...onical.com> > --- > security/apparmor/apparmorfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/security/apparmor/apparmorfs.c b/security/apparmor/apparmorfs.c > index be0b498..4f6ac9d 100644 > --- a/security/apparmor/apparmorfs.c > +++ b/security/apparmor/apparmorfs.c > @@ -1357,7 +1357,7 @@ static int aa_mk_null_file(struct dentry *parent) > > inode->i_ino = get_next_ino(); > inode->i_mode = S_IFCHR | S_IRUGO | S_IWUGO; > - inode->i_atime = inode->i_mtime = inode->i_ctime = CURRENT_TIME; > + inode->i_atime = inode->i_mtime = inode->i_ctime = current_time(inode); > init_special_inode(inode, S_IFCHR | S_IRUGO | S_IWUGO, > MKDEV(MEM_MAJOR, 3)); > d_instantiate(dentry, inode); >
Powered by blists - more mailing lists