linux-kernel - Re: [PATCH] rpmsg: virtio_rpmsg_bus: cleanup multiple assignment to ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <053186d1-f05d-06e0-2fa9-e15bcfa5bb02@ti.com>
Date:   Fri, 2 Jun 2017 16:40:15 -0500
From:   Suman Anna <s-anna@...com>
To:     Henri Roosen <henri.roosen@...zinger.com>,
        <linux-remoteproc@...r.kernel.org>
CC:     Ohad Ben-Cohen <ohad@...ery.com>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] rpmsg: virtio_rpmsg_bus: cleanup multiple assignment to
 ops

On 06/02/2017 06:36 AM, Henri Roosen wrote:
> Trivial cleanup: the .ops pointer is assigned twice. This patch removes the
> first assignment.
> 
> Signed-off-by: Henri Roosen <henri.roosen@...zinger.com>

Acked-by: Suman Anna <s-anna@...com>

> ---
>  drivers/rpmsg/virtio_rpmsg_bus.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c b/drivers/rpmsg/virtio_rpmsg_bus.c
> index 3c582f2..35b8379 100644
> --- a/drivers/rpmsg/virtio_rpmsg_bus.c
> +++ b/drivers/rpmsg/virtio_rpmsg_bus.c
> @@ -390,9 +390,6 @@ static struct rpmsg_device *rpmsg_create_channel(struct virtproc_info *vrp,
>  	/* Link the channel to our vrp */
>  	vch->vrp = vrp;
>  
> -	/* Assign callbacks for rpmsg_channel */
> -	vch->rpdev.ops = &virtio_rpmsg_ops;
> -
>  	/* Assign public information to the rpmsg_device */
>  	rpdev = &vch->rpdev;
>  	rpdev->src = chinfo->src;
>