linux-kernel - Re: [PATCH 1/3] arm/xen: Improve a size determination in __set_phys_to_machine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.10.1706051016310.2941@sstabellini-ThinkPad-X260>
Date:   Mon, 5 Jun 2017 10:16:46 -0700 (PDT)
From:   Stefano Stabellini <sstabellini@...nel.org>
To:     SF Markus Elfring <elfring@...rs.sourceforge.net>
cc:     linux-arm-kernel@...ts.infradead.org,
        xen-devel@...ts.xenproject.org,
        Russell King <linux@...linux.org.uk>,
        Stefano Stabellini <sstabellini@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 1/3] arm/xen: Improve a size determination in
 __set_phys_to_machine_multi()

On Sun, 4 Jun 2017, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Sun, 4 Jun 2017 20:50:55 +0200
> 
> Replace the specification of a data structure by a pointer dereference
> as the parameter for the operator "sizeof" to make the corresponding size
> determination a bit safer according to the Linux coding style convention.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>

Reviewed-by: Stefano Stabellini <sstabellini@...nel.org>


> ---
>  arch/arm/xen/p2m.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/xen/p2m.c b/arch/arm/xen/p2m.c
> index 0ed01f2d5ee4..11e78432b663 100644
> --- a/arch/arm/xen/p2m.c
> +++ b/arch/arm/xen/p2m.c
> @@ -144,5 +144,5 @@ bool __set_phys_to_machine_multi(unsigned long pfn,
>  		return true;
>  	}
>  
> -	p2m_entry = kzalloc(sizeof(struct xen_p2m_entry), GFP_NOWAIT);
> +	p2m_entry = kzalloc(sizeof(*p2m_entry), GFP_NOWAIT);
>  	if (!p2m_entry) {
> -- 
> 2.13.0
>