linux-kernel - Re: [PATCH 2/3] arm/xen: Delete an error message for a failed memory allocation in __set_phys_to_machine_multi()

Open Source and information security mailing list archives

Message-ID: <alpine.DEB.2.10.1706051016590.2941@sstabellini-ThinkPad-X260>
Date:   Mon, 5 Jun 2017 10:17:29 -0700 (PDT)
From:   Stefano Stabellini <sstabellini@...nel.org>
To:     SF Markus Elfring <elfring@...rs.sourceforge.net>
cc:     linux-arm-kernel@...ts.infradead.org,
        xen-devel@...ts.xenproject.org,
        Russell King <linux@...linux.org.uk>,
        Stefano Stabellini <sstabellini@...nel.org>,
        kernel-janitors@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/3] arm/xen: Delete an error message for a failed memory
 allocation in __set_phys_to_machine_multi()

On Sun, 4 Jun 2017, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Sun, 4 Jun 2017 21:12:36 +0200
> 
> Omit an extra message for a memory allocation failure in this function.
> 
> This issue was detected by using the Coccinelle software.
> 
> Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>

Reviewed-by: Stefano Stabellini <sstabellini@...nel.org>

> ---
>  arch/arm/xen/p2m.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/xen/p2m.c b/arch/arm/xen/p2m.c
> index 11e78432b663..f5f74ac637b9 100644
> --- a/arch/arm/xen/p2m.c
> +++ b/arch/arm/xen/p2m.c
> @@ -148,7 +148,6 @@ bool __set_phys_to_machine_multi(unsigned long pfn,
> -	if (!p2m_entry) {
> -		pr_warn("cannot allocate xen_p2m_entry\n");
> +	if (!p2m_entry)
>  		return false;
> -	}
> +
>  	p2m_entry->pfn = pfn;
>  	p2m_entry->nr_pages = nr_pages;
>  	p2m_entry->mfn = mfn;
> -- 
> 2.13.0
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives