linux-kernel - Re: mtd: nand: fsl_ifc: fix handing of bit flips in erased pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1496872770936.46522@alliedtelesis.co.nz>
Date:   Wed, 7 Jun 2017 21:59:32 +0000
From:   Darwin Dingel <Darwin.Dingel@...iedtelesis.co.nz>
To:     Pavel Machek <pavel@....cz>
CC:     Boris Brezillon <boris.brezillon@...e-electrons.com>,
        "richard@....at" <richard@....at>,
        "dwmw2@...radead.org" <dwmw2@...radead.org>,
        "computersforpeace@...il.com" <computersforpeace@...il.com>,
        "marek.vasut@...il.com" <marek.vasut@...il.com>,
        "cyrille.pitchen@...el.com" <cyrille.pitchen@...el.com>,
        "linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "mark.marshall@...cronenergy.com" <mark.marshall@...cronenergy.com>,
        "b44839@...escale.com" <b44839@...escale.com>,
        "prabhakar@...escale.com" <prabhakar@...escale.com>
Subject: Re: mtd: nand: fsl_ifc: fix handing of bit flips in erased pages

Hi Pavel,

Looks like uboot has similar IFC driver. Do you have plans to apply this change to uboot as well?

Cheers,
Darwin

From: Pavel Machek <pavel@....cz>
Sent: Thursday, 1 June 2017 10:15 a.m.
To: Darwin Dingel
Cc: Boris Brezillon; richard@....at; dwmw2@...radead.org; computersforpeace@...il.com; marek.vasut@...il.com; cyrille.pitchen@...el.com; linux-mtd@...ts.infradead.org; linux-kernel@...r.kernel.org; mark.marshall@...cronenergy.com; b44839@...escale.com;  prabhakar@...escale.com
Subject: Re: mtd: nand: fsl_ifc: fix handing of bit flips in erased pages

Hi!

> > You meen "errors = 0"? Does that actually make a difference? It is a
> > local variable, and continue makes sure the value is not used:
> > 
> 
> I missed the 'continue' statement there. In that case we don't need to 
> reset 'error'.

Yes, thanks, I wanted to double-check. If you could take a look at
PATCHv2 -- it should have the problems fixed. Your Acked-by would be
nice ;-).

Thanks a lot,
                                                                        Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures)  http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html