lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [day] [month] [year] [list]
Message-ID: <20170607152747.Horde.8JNiGUjUVmaDvwXKaBUwN0t@gator4166.hostgator.com>
Date:   Wed, 07 Jun 2017 15:27:47 -0500
From:   "Gustavo A. R. Silva" <garsilva@...eddedor.com>
To:     Adaptec OEM Raid Solutions <aacraid@...ptec.com>,
        "James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>
Cc:     linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        "Gustavo A. R. Silva" <garsilva@...eddedor.com>
Subject: [PATCH] scsi: remove useless variable assignment


Remove both variable assignments once the value stored in variable _reqlen_
is overwritten at some point either by line 2321: reqlen = mptr - msg;
or by line 2330: reqlen = 12;

Addresses-Coverity-ID: 1226930
Addresses-Coverity-ID: 1226931
Signed-off-by: Gustavo A. R. Silva <garsilva@...eddedor.com>
---
  drivers/scsi/dpt_i2o.c | 3 ---
  1 file changed, 3 deletions(-)

diff --git a/drivers/scsi/dpt_i2o.c b/drivers/scsi/dpt_i2o.c
index 256dd67..acad668 100644
--- a/drivers/scsi/dpt_i2o.c
+++ b/drivers/scsi/dpt_i2o.c
@@ -2292,11 +2292,8 @@ static s32 adpt_scsi_to_i2o(adpt_hba* pHba,  
struct scsi_cmnd* cmd, struct adpt_d
  	mptr+=4;
  	lenptr=mptr++;		/* Remember me - fill in when we know */
  	if (dpt_dma64(pHba)) {
-		reqlen = 16;		// SINGLE SGE
  		*mptr++ = (0x7C<<24)+(2<<16)+0x02; /* Enable 64 bit */
  		*mptr++ = 1 << PAGE_SHIFT;
-	} else {
-		reqlen = 14;		// SINGLE SGE
  	}
  	/* Now fill in the SGList and command */

--
2.5.0





Download attachment "Forwarded Message" of type "message/rfc822" (2122 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ