linux-kernel - Re: [PATCH] watchdog: davinci: Add missing clk_disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170607205125.GB29222@roeck-us.net>
Date:   Wed, 7 Jun 2017 13:51:25 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     wim@...ana.be, linux-watchdog@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] watchdog: davinci: Add missing clk_disable_unprepare().

On Tue, Jun 06, 2017 at 04:08:31PM +0530, Arvind Yadav wrote:
> davinci_wdt_probe() can fail here and we must disable clock.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

... though I would really prefer to have devm_clk_prepare_enable()
instead :-(.

> ---
>  drivers/watchdog/davinci_wdt.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/watchdog/davinci_wdt.c b/drivers/watchdog/davinci_wdt.c
> index 1ba9ead..2f46487 100644
> --- a/drivers/watchdog/davinci_wdt.c
> +++ b/drivers/watchdog/davinci_wdt.c
> @@ -202,8 +202,10 @@ static int davinci_wdt_probe(struct platform_device *pdev)
>  		return PTR_ERR(davinci_wdt->base);
>  
>  	ret = watchdog_register_device(wdd);
> -	if (ret < 0)
> +	if (ret < 0) {
> +		clk_disable_unprepare(davinci_wdt->clk);
>  		dev_err(dev, "cannot register watchdog device\n");
> +	}
>  
>  	return ret;
>  }
> -- 
> 1.9.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html