linux-kernel - Re: [PATCH V2 2/3] watchdog: uniphier: add UniPhier watchdog driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 8 Jun 2017 11:09:41 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     Keiji Hayashibara <hayashibara.keiji@...ionext.com>
Cc:     wim@...ana.be, Guenter Roeck <linux@...ck-us.net>,
        linux-watchdog@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org,
        Masami Hiramatsu <masami.hiramatsu@...aro.org>,
        Jassi Brar <jaswinder.singh@...aro.org>,
        Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>,
        Kiyoshi Owada <owada.kiyoshi@...ionext.com>
Subject: Re: [PATCH V2 2/3] watchdog: uniphier: add UniPhier watchdog driver

Hayashibara-san

Just a nit.


> +
> +#include <linux/module.h>
> +#include <linux/mfd/syscon.h>
> +#include <linux/of.h>
> +#include <linux/platform_device.h>
> +#include <linux/regmap.h>
> +#include <linux/watchdog.h>
> +#include <linux/bitops.h>

I think you should have added <linux/bitops.h> on the top
to keep the includes alphabetically sorted.


-- 
Best Regards
Masahiro Yamada