linux-kernel - Re: [PATCH V2 1/3] devicetree: add UniPhier WDT devicetree bindings documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK7LNATMRPW3PYU-fX+biRdez-mgkUKRbVi+w+dBNb3szOuXdw@mail.gmail.com>
Date:   Thu, 8 Jun 2017 11:11:00 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     Keiji Hayashibara <hayashibara.keiji@...ionext.com>
Cc:     wim@...ana.be, Guenter Roeck <linux@...ck-us.net>,
        linux-watchdog@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org,
        Masami Hiramatsu <masami.hiramatsu@...aro.org>,
        Jassi Brar <jaswinder.singh@...aro.org>,
        Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>,
        Kiyoshi Owada <owada.kiyoshi@...ionext.com>
Subject: Re: [PATCH V2 1/3] devicetree: add UniPhier WDT devicetree bindings documentation

Hayashibara-san


Just nitpicking.


2017-06-06 18:11 GMT+09:00 Keiji Hayashibara <hayashibara.keiji@...ionext.com>:
> Add uniphier-wdt bindings documentation.
>
> Signed-off-by: Keiji Hayashibara <hayashibara.keiji@...ionext.com>


Maybe "dt-bindings: watchdog: ..." for the subject.

This seems what Rob prefers.

For example,
https://patchwork.kernel.org/patch/9606365/



> ---
>  .../devicetree/bindings/watchdog/uniphier-wdt.txt    | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/watchdog/uniphier-wdt.txt
>
> diff --git a/Documentation/devicetree/bindings/watchdog/uniphier-wdt.txt b/Documentation/devicetree/bindings/watchdog/uniphier-wdt.txt
> new file mode 100644
> index 0000000..a59d1ba
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/watchdog/uniphier-wdt.txt
> @@ -0,0 +1,20 @@
> +UniPhier watchdog timer controller
> +
> +This UniPhier watchdog timer controller must be under sysctrl compatible node.

Do you mean "syscon compatible" ?


> +Required properties:
> +- compatible: should be "socionext,uniphier-wdt"
> +
> +Example:
> +
> +       sysctrl@...40000 {
> +               compatible = "socionext,uniphier-ld11-sysctrl",
> +                            "simple-mfd", "syscon";
> +               reg = <0x61840000 0x4000>;
> +
> +               sys_wdt: watchdog {
> +                       compatible = "socionext,uniphier-wdt";
> +               }

Could you remove the "sys_dwt: " label?
I'd like the example matched with actual DT files.


Thanks.


> +               other nodes ...
> +       };
> --
> 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Best Regards
Masahiro Yamada