linux-kernel - RE: [PATCH V2 2/3] watchdog: uniphier: add UniPhier watchdog driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <000001d2e01b$41b00840$c51018c0$@socionext.com>
Date:   Thu, 8 Jun 2017 14:51:21 +0900
From:   "Keiji Hayashibara" <hayashibara.keiji@...ionext.com>
To:     Yamada, Masahiro/山田 真弘 
        <yamada.masahiro@...ionext.com>
Cc:     <wim@...ana.be>, "Guenter Roeck" <linux@...ck-us.net>,
        <linux-watchdog@...r.kernel.org>,
        "Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>,
        "Rob Herring" <robh+dt@...nel.org>, <devicetree@...r.kernel.org>,
        "Masami Hiramatsu" <masami.hiramatsu@...aro.org>,
        "Jassi Brar" <jaswinder.singh@...aro.org>,
        Hayashi, Kunihiko/林 邦彦 
        <hayashi.kunihiko@...ionext.com>,
        Owada, Kiyoshi/大和田 清志 
        <owada.kiyoshi@...ionext.com>
Subject: RE: [PATCH V2 2/3] watchdog: uniphier: add UniPhier watchdog driver

Hello Yamada-san,

> > +
> > +#include <linux/module.h>
> > +#include <linux/mfd/syscon.h>
> > +#include <linux/of.h>
> > +#include <linux/platform_device.h>
> > +#include <linux/regmap.h>
> > +#include <linux/watchdog.h>
> > +#include <linux/bitops.h>
> 
> I think you should have added <linux/bitops.h> on the top
> to keep the includes alphabetically sorted.

Sorry, I will fix in v3 patch.

----------
Best Regards,
Keiji Hayashibara