linux-kernel - RE: [PATCH V2 1/3] devicetree: add UniPhier WDT devicetree bindings documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <000101d2e01f$913fef20$b3bfcd60$@socionext.com>
Date:   Thu, 8 Jun 2017 15:22:12 +0900
From:   "Keiji Hayashibara" <hayashibara.keiji@...ionext.com>
To:     Yamada, Masahiro/山田 真弘 
        <yamada.masahiro@...ionext.com>
Cc:     <wim@...ana.be>, "Guenter Roeck" <linux@...ck-us.net>,
        <linux-watchdog@...r.kernel.org>,
        "Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>,
        "Rob Herring" <robh+dt@...nel.org>, <devicetree@...r.kernel.org>,
        "Masami Hiramatsu" <masami.hiramatsu@...aro.org>,
        "Jassi Brar" <jaswinder.singh@...aro.org>,
        Hayashi, Kunihiko/林 邦彦 
        <hayashi.kunihiko@...ionext.com>,
        Owada, Kiyoshi/大和田 清志 
        <owada.kiyoshi@...ionext.com>
Subject: RE: [PATCH V2 1/3] devicetree: add UniPhier WDT devicetree bindings documentation

Hello Yamada-san

Thank you for your comment.

> > Add uniphier-wdt bindings documentation.
> >
> > Signed-off-by: Keiji Hayashibara <hayashibara.keiji@...ionext.com>
> 
> 
> Maybe "dt-bindings: watchdog: ..." for the subject.
> 
> This seems what Rob prefers.
> 
> For example,
> https://patchwork.kernel.org/patch/9606365/

OK. I will change the subject in v3 patch.

> 
> > ---
> >  .../devicetree/bindings/watchdog/uniphier-wdt.txt    | 20 ++++++++++++++++++++
> >  1 file changed, 20 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/watchdog/uniphier-wdt.txt
> >
> > diff --git a/Documentation/devicetree/bindings/watchdog/uniphier-wdt.txt
> b/Documentation/devicetree/bindings/watchdog/uniphier-wdt.txt
> > new file mode 100644
> > index 0000000..a59d1ba
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/watchdog/uniphier-wdt.txt
> > @@ -0,0 +1,20 @@
> > +UniPhier watchdog timer controller
> > +
> > +This UniPhier watchdog timer controller must be under sysctrl compatible node.
> 
> Do you mean "syscon compatible" ?

The "compatible" word is inappropriate.
I will remove it in v3 patch.

> 
> > +Required properties:
> > +- compatible: should be "socionext,uniphier-wdt"
> > +
> > +Example:
> > +
> > +       sysctrl@...40000 {
> > +               compatible = "socionext,uniphier-ld11-sysctrl",
> > +                            "simple-mfd", "syscon";
> > +               reg = <0x61840000 0x4000>;
> > +
> > +               sys_wdt: watchdog {
> > +                       compatible = "socionext,uniphier-wdt";
> > +               }
> 
> Could you remove the "sys_dwt: " label?
> I'd like the example matched with actual DT files.

I will remove it.

> 
> Thanks.
> 
> 
> > +               other nodes ...
> > +       };
> > --
> > 2.7.4
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
> > the body of a message to majordomo@...r.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html

----------
Best Regards,
Keiji Hayashibara