linux-kernel - Re: [PATCH] regmap: make LZO cache optional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <13f337ad-83ba-5542-0d6f-61282d2afce2@fau.de>
Date:   Thu, 8 Jun 2017 16:28:25 +0200
From:   Andreas Ziegler <andreas.ziegler@....de>
To:     Jonas Gorski <jonas.gorski@...il.com>
Cc:     Mark Brown <broonie@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] regmap: make LZO cache optional

Hi Jonas,

I noticed your patch 'regmap: make LZO cache optional' as it recently showed up
in linux-next. In your patch, you modify drivers/base/regmap/regcache.c by
adding an #if IS_ENABLED() statement.

However, this statement contains a spelling error, as it references
REGCHACHE_COMPRESSED instead of REGCACHE_COMPRESSED (note the extra H).

I noticed it by running the in-tree script at scripts/checkkconfigsymbols.py on
the commit, like so: './scripts/checkkconfigsymbols.py -c 34a730aa74c7'

As Greg suggested the whole code could be dropped, this might not be too
relevant, but I wanted to let you know in any case.

Best regards,

Andreas

Download attachment "smime.p7s" of type "application/pkcs7-signature" (5450 bytes)