linux-kernel - Re: [PATCH] regmap: make LZO cache optional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOiHx=mr5KK_LhDd1DTHZc6i3+9yG1=MYV0oN28Q2-QB0PJydg@mail.gmail.com>
Date:   Sun, 11 Jun 2017 12:26:04 +0200
From:   Jonas Gorski <jonas.gorski@...il.com>
To:     Andreas Ziegler <andreas.ziegler@....de>
Cc:     Mark Brown <broonie@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] regmap: make LZO cache optional

Hi Andreas,

On 8 June 2017 at 16:28, Andreas Ziegler <andreas.ziegler@....de> wrote:
> Hi Jonas,
>
> I noticed your patch 'regmap: make LZO cache optional' as it recently showed up
> in linux-next. In your patch, you modify drivers/base/regmap/regcache.c by
> adding an #if IS_ENABLED() statement.
>
> However, this statement contains a spelling error, as it references
> REGCHACHE_COMPRESSED instead of REGCACHE_COMPRESSED (note the extra H).
>
> I noticed it by running the in-tree script at scripts/checkkconfigsymbols.py on
> the commit, like so: './scripts/checkkconfigsymbols.py -c 34a730aa74c7'
>
> As Greg suggested the whole code could be dropped, this might not be too
> relevant, but I wanted to let you know in any case.

Thanks for spotting that, and I wasn't aware of this script, that
seems quite useful!


Regards
Jonas